Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up client/server transport shutdown #4459

Closed
dfawley opened this issue May 18, 2021 · 0 comments
Closed

Clean up client/server transport shutdown #4459

dfawley opened this issue May 18, 2021 · 0 comments

Comments

@dfawley
Copy link
Member

dfawley commented May 18, 2021

From #4447:

We should cleanup the transport code later (when? 🤷‍♂️).

  • the channel (controlbuf) is closed by the reader (loopyWriter()) instead of the writer (reader()) (hahahahaha)
    • which is, counterintuitive
  • the multiple caller of t.Close() is probably part of the cause that RPCs tend to fail with transport is closing
    • if the transport is only closed by the reader(), and the other places just tells reader() to close, it might make things cleaner
@dfawley dfawley closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant