balancergroup: fix leak child balancer not closed #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Mar 31, 2021
| // Immediately close balancergroup, before the cache timeout | ||
| bg.Close() | ||
|
|
||
| // Make sure the remove child balancer is closed. |
There was a problem hiding this comment.
Nit: s/remove/removed/ (or remove remove?)
menghanl
force-pushed
the
balancergroup_leak_child
branch
from
99658c4
to
59e211f
Compare
…k child balancer not closed
menghanl
force-pushed
the
balancergroup_leak_child
branch
from
59e211f
to
1473e61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child policies in balancergroup are put into a cache when they are removed (and will be closed later after a timeout).
When balancergroup is closed, we clear the cache, so that child policies will be immediately closed.
Before this change, we first mark balancergroup as closed (
bg.outgoingStarted = false), then clear the cache (bg.balancerCache.Clear(true)). This makes the cache clear a noop, so the child in cache will be leaked.This change moves
cache.Clearbefore marking balancergroup as closed.