xds/resolver: support inline RDS resource from LDS response #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Mar 25, 2021
| // inline RDS resource. | ||
|
|
||
| // If there was an RDS watch, cancel it. | ||
| if w.rdsName != "" { |
There was a problem hiding this comment.
This outer if seems unnecessary.
| return | ||
| } | ||
|
|
||
| // RDS name from update is not an empty string, start RDS watch. |
There was a problem hiding this comment.
This seems like it's documenting the if immediately below, but it isn't.
There was a problem hiding this comment.
Modified (a little bit).
dfawley
approved these changes
Mar 26, 2021
menghanl
force-pushed
the
lds_rds_inline
branch
from
3d71af7
to
75f1d68
Compare
easwars
reviewed
Mar 30, 2021
menghanl
force-pushed
the
lds_rds_inline
branch
from
c258eac
to
4475811
Compare
easwars
approved these changes
Mar 31, 2021
| @@ -110,6 +110,24 @@ func (w *serviceUpdateWatcher) handleLDSResp(update xdsclient.ListenerUpdate, er | |||
| httpFilterConfig: update.HTTPFilters, | |||
| } | |||
|
|
|||
| if update.InlineRouteConfig != nil { | |||
| // The LDS resp received has an inline RDS resource. | |||
There was a problem hiding this comment.
Nit: maybe get rid of this comment?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by direct path.