Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interop: allow client to make Traffic Director RPCs #4291

Merged
merged 3 commits into from Mar 26, 2021
Merged

interop: allow client to make Traffic Director RPCs #4291

merged 3 commits into from Mar 26, 2021

Conversation

apolcyn
Copy link
Contributor

@apolcyn apolcyn commented Mar 25, 2021 •
edited

This is needed to allow the interop client to be used with Traffic Director load balancing

The behavior of allowing a server_port of zero to mean "no port" was added to the C++ interop client in grpc/grpc#25550 and to the Java interop client in grpc/grpc-java#7994

@apolcyn
Copy link
Contributor Author

apolcyn commented Mar 25, 2021

The failure looks unrelated to this PR:

--- FAIL: Test (80.90s)
    --- FAIL: Test/KeepaliveClientStaysHealthyWithResponsiveServer (4.00s)
        keepalive_test.go:367: client.NewStream() failed: connection error: desc = "transport is closing"
FAIL
FAIL	google.golang.org/grpc/internal/transport	163.261s

@apolcyn apolcyn changed the title Make --server_port optional in interop client Allow using interop client for making Traffic Director RPCs Mar 25, 2021
@apolcyn
Copy link
Contributor Author

apolcyn commented Mar 26, 2021

@dfawley if this looks good, can you merge? I don't have merge permissions on this repo.

@menghanl menghanl merged commit 2456c5c into grpc:master Mar 26, 2021
@dfawley dfawley changed the title Allow using interop client for making Traffic Director RPCs interop: allow client to make Traffic Director RPCs Mar 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@apolcyn apolcyn

Labels
Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apolcyn @dfawley @menghanl