circuit breaking: update picker inline when there's a counter update #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne when there's a counter update Otherwise, if there's no further picker update, the new counter will never be used.
|
Manual interop test passed. |
easwars
approved these changes
Feb 18, 2021
| if edsImpl.serviceRequestsCounter == nil || edsImpl.serviceRequestsCounter.ServiceName != serviceName { | ||
| edsImpl.serviceRequestsCounter = client.GetServiceRequestsCounter(serviceName) | ||
| updatePicker = true | ||
| } | ||
| if max != nil { |
There was a problem hiding this comment.
Do we need to check edsImpl.serviceRequestCountMax != *max before setting updatePicker = true?
There was a problem hiding this comment.
Good catch.
This is also not handling nil properly.
Fixed
| edsb.updateServiceRequestsConfig("test", &maxRequests2) | ||
|
|
||
| // Picks with drops. | ||
| dones2 := []func(){} |
There was a problem hiding this comment.
Can't we just use dones here as well? Do we need dones2?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if there's no further picker update, the new counter will never be used.
Regression caused by #4203
This is handled in
cluster_impl, but missed ineds.