balancergroup: Propagate balancer.BuildOptions to child policies #4184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
approved these changes
Feb 4, 2021
| @@ -590,16 +594,20 @@ func (s) TestBalancerGroup_start_close(t *testing.T) { | |||
| // whenever it gets an address update. It's expected that start() doesn't block | |||
| // because of deadlock. | |||
| func (s) TestBalancerGroup_start_close_deadlock(t *testing.T) { | |||
| const balancerName = "stub-TestBalancerGroup_start_close_deadlock" | |||
| stub.Register(balancerName, stub.BalancerFuncs{}) | |||
There was a problem hiding this comment.
Another option is to export stub.bb, and add a NewBB(). So you don't need to register and get.
There was a problem hiding this comment.
I will send a separate PR for that since I would have to touch other existing call sites as well. Thanks.
|
|
||
| // Send an empty clientConn state change. This should trigger the | ||
| // verification of the buildOptions being passed to the child policy. | ||
| bg.UpdateClientConnState(testBalancerIDs[0], balancer.ClientConnState{}) |
There was a problem hiding this comment.
Does this function not return the error from the stub?
If it does, we don't need ccsCh, right?
I think balancergroup calls the methods inline.
Unlike e.g. cluster_manager, where we get errors from bg.UpdateClientConnState, but we don't aggregate and return that error. So ccsCh would be necessary.
There was a problem hiding this comment.
Thanks for the catch. Done.
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes:
balancergroup.New()is modified to takebalancer.BuildOptionsas its second argument.balancer.BuildOptionsis passed to child policies when they are constructed.balancergroup, it is better to take thebalancer.BuildOptionsas part ofNew()instead of as part ofAdd().Other changes:
clustermanager,edsandweightedtargetLB policies to passbalancer.BuildOptionsto thebalancergroup.balancer.BuildOptionsare propagated properly.testutils.TestConstBalancerBuilderand usestub.Balancerinstead.Fixes #4185