xds bootstrap: support config content in env variable #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Jan 14, 2021
dfawley
approved these changes
Jan 15, 2021
| return []byte(fContent), nil | ||
| } | ||
|
|
||
| return nil, fmt.Errorf("none of the bootstrap environment variables (%q or %q) defined", "GRPC_XDS_BOOTSTRAP", "GRPC_XDS_BOOTSTRAP_CONFIG") |
There was a problem hiding this comment.
Should we export consts for those strings and reference them here?
There was a problem hiding this comment.
We do have consts for them, but they are in another package.
Exported those and used them here.
dfawley
approved these changes
Jan 15, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRPC_XDS_BOOTSTRAPexists then use its value as the name of the bootstrap file. If the file is missing or the contents of the file are malformed, return an error.GRPC_XDS_BOOTSTRAP_CONFIGexists then use its value as the bootstrap config. If the value is malformed, return an error.fixes #4127