xds: NACK more invalid RDS responses #4120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unrecognized path specifier - including Regex (not SafeRegex) from xds v2 - unrecognized header matcher specifier - empty action weighted clusters
dfawley
reviewed
Dec 17, 2020
xds/internal/client/client_xds.go
Outdated
Comment on lines
337
to
339
| if totalWeight == 0 { | ||
| return nil, fmt.Errorf("route %+v, action %+v, has no cluster in WeightedCluster action", r, a) | ||
| } |
There was a problem hiding this comment.
Is a zero weight for a cluster valid?
If so, then is total weight of zero valid if there are clusters?
If not, should we nack if we get a zero value on line 330?
There was a problem hiding this comment.
C and Java have different behaviors.
C would ignore weight 0, and if there is no remaining cluster, NACK.
Java processes weight 0 as normal.
Need to find what Envoy does.
Will make the fix after there's a conclusion.
There was a problem hiding this comment.
Made the change to ignore 0-weight clusters. And will still NACK if there's no clusters remaining after filtering.
dfawley
approved these changes
Dec 18, 2020
dfawley
pushed a commit
to dfawley/grpc-go
that referenced
this pull request
Jan 5, 2021
dfawley
pushed a commit
to dfawley/grpc-go
that referenced
this pull request
Jan 5, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4093