protobuf: update protoc to latest version #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presently, protoc 3.3.0 (released in 2017) is still being used. This commit updates the vet.sh script as well as existing generated files to use protoc instead. The only concrete change this brings is updated import paths of Timestamp and Duration types. However, in practice this is a no-op, since the types themselves are already aliased to the new import path: - https://pkg.go.dev/github.com/golang/protobuf@v1.4.3/ptypes/duration#Duration - https://pkg.go.dev/github.com/golang/protobuf@v1.4.3/ptypes/timestamp#Timestamp
|
|
dfawley
approved these changes
Nov 17, 2020
davidkhala
pushed a commit
to Hyperledger-TWGC/grpc
that referenced
this pull request
Dec 7, 2020
Presently, protoc 3.3.0 (released in 2017) is still being used. This commit updates the vet.sh script as well as existing generated files to use protoc 3.14.0 instead. The only concrete change this brings is updated import paths of Timestamp and Duration types. However, in practice this is a no-op, since the types themselves are already aliased to the new import path: - https://pkg.go.dev/github.com/golang/protobuf@v1.4.3/ptypes/duration#Duration - https://pkg.go.dev/github.com/golang/protobuf@v1.4.3/ptypes/timestamp#Timestamp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, protoc 3.3.0 (released in 2017) is still being used. This commit updates the vet.sh script as well as existing generated files to use protoc 3.14.0 instead.
The only concrete change this brings is updated import paths of Timestamp and Duration types. However, in practice this is a no-op, since the types themselves are already aliased to the new import path: