github: add Github Actions workflow for tests; support in vet.sh #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
approved these changes
Oct 30, 2020
|
|
||
| # Run the vet checks. | ||
| - name: vet | ||
| run: ./vet.sh -install && ./vet.sh |
There was a problem hiding this comment.
This workflow runs vet (gofmt/golint...) twice now.
Should we move the proto regen part out to it's own job?
There was a problem hiding this comment.
I was thinking as a follow-up change I would add an option to vet to make it ONLY run the proto checks. WDYT?
There was a problem hiding this comment.
SG.
Do the proto checks need anything from vet.sh? Or just move it to a separate .sh
There was a problem hiding this comment.
They both need the checks up front to make sure your branch is clean & revert any changes it makes to it.
I would probably keep them together to support the "running offline" use-case better. VET_ONLY_PROTO=1 or something?
GarrettGutierrez1
pushed a commit
that referenced
this pull request
Nov 6, 2020
davidkhala
pushed a commit
to Hyperledger-TWGC/grpc
that referenced
this pull request
Dec 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.