Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: remove Error method accidentally added to *Status #3561

Merged
merged 1 commit into from Apr 23, 2020

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Apr 22, 2020

This is a serious problem for it to exist, as it allows an OK status to have a non-nil error representation.

internal/status/status.go Show resolved Hide resolved
@dfawley dfawley merged commit 8f94cb1 into grpc:master Apr 23, 2020
@dfawley dfawley deleted the status_not_error branch April 23, 2020 15:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants