balancer: change roundrobin to accept empty address list #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… healthy endpoints TODO empty locality should result in transient failure. Needs to fix RoundRobin tests: - if a locality contains no endpoints - if this is the first update - if this is not the first update
dfawley
reviewed
Apr 1, 2020
| for src := cc.GetState(); src == connectivity.Ready; src = cc.GetState() { | ||
| if !cc.WaitForStateChange(ctx, src) { | ||
| t.Fatalf("timed out waiting for state change. got %v; want !%v", src, connectivity.Ready) | ||
| ctx2, cancel2 := context.WithTimeout(context.Background(), 50*time.Millisecond) |
There was a problem hiding this comment.
Is this enough time? a few seconds should be fine before detecting the failure.
| const msgWant = "produced zero addresses" | ||
| if _, err := testc.EmptyCall(ctx, &testpb.Empty{}); err == nil || !strings.Contains(status.Convert(err).Message(), msgWant) { | ||
| t.Fatalf("EmptyCall() = _, %v, want _, Contains(Message(), %q)", err, msgWant) | ||
| if _, err := testc.EmptyCall(ctx2, &testpb.Empty{}, grpc.WaitForReady(true)); status.Code(err) != codes.DeadlineExceeded { |
There was a problem hiding this comment.
We cannot. The balancer no longer sets the error. This will be a pure deadline exceeded error.
There was a problem hiding this comment.
We can. This is done now.
We won't start to report "zero addresses" immediately, but will when all the connections are down.
The previous change to combine resolver errors with transient errors still makes sense here.
| p1 := <-cc.newPickerCh | ||
| want := []balancer.SubConn{sc1} | ||
| if err := isRoundRobin(want, subConnFromPicker(p1)); err != nil { | ||
| // t.Fatalf("want %v, got %v", want, err) |
There was a problem hiding this comment.
Done. (There are a lot of them..)
dfawley
approved these changes
Apr 3, 2020
menghanl
added a commit
that referenced
this pull request
Apr 3, 2020
Roundrobin will remove all SubConns. The ClientConn will set SubConn state change to shutdown, and the overall state will turn transient failure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roundrobin will remove all SubConns. The ClientConn will set SubConn state change to shutdown, and the overall state will turn transient failure.