client: add a WithNoProxy dialoption

[pdbogen]

Hullo! I'm working with a system that talks to some things via grpc and some things not via grpc. (actually, talking over a UNIX domain socket via grpc 😬).

The non-grpc things are mostly HTTP requests that we do need to proxy. The grpc things, as noted, as via local sockets, which can't and shouldn't be proxied.

Providing our own dialer is an option, but this seems a little cleaner and like other folks might also find it useful.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Patrick Bogen (17279ac, ba34f11, 7194582)

[stale]

This issue is labeled as requiring an update from the reporter, and no update has been received after 7 days. If no update is provided in the next 7 days, this issue will be automatically closed.

[easwars]

ping @pdbogen

[pdbogen]

Thanks for the ping, and for your patience! The original requests for change came in while I was on vacation, so I'd forgotten about them.

[menghanl]

Thanks for the fix. LGTM!

[thaJeztah]

#3411 (comment)

Can you make this withProxy, and set it to true in defaultDialOptions()? So we don't have "if not without proxy".

@menghanl Isn't that a breaking change? I saw this feature in the changelog (knowing that we did something similar in moby/swarmkit#2802), but if consumers of this package setup their own grpc.ClientConn (not using the defaultDialOptions()), they'll end up with a change in behavior?

I think withoutProxy was the better choice, so that the default for the bool (false) is also the default to use.

[thaJeztah]

Ehm, ignore my comment, had my wires crossed; blame it on "commenting before enough coffee"