test: add test of malformed gzip payload #3141
Conversation
test/end2end_test.go
Outdated
| } | ||
| err := gzw.Close() | ||
| bs := buf.Bytes() | ||
| bs[len(bs)-4] -= 1 // modify checksum (big endian) at end by 1 byte |
There was a problem hiding this comment.
lint: should replace bs[len(bs)-4] -= 1 with bs[len(bs)-4]--
test/end2end_test.go
Outdated
|
|
||
| p, err := newPayload(testpb.PayloadType_COMPRESSABLE, int32(1024)) | ||
| if err != nil { | ||
| panic(err) |
test/end2end_test.go
Outdated
| if err != nil { | ||
| panic(err) | ||
| } | ||
| if _, err := ss.client.UnaryCall(ctx, &testpb.SimpleRequest{Payload: p}); err == nil || status.Code(err) != codes.Internal { |
There was a problem hiding this comment.
Do we expect the error to contain gzip error message (gzip.ErrChecksum https://golang.org/pkg/compress/gzip/#pkg-variables)?
test/end2end_test.go
Outdated
| return "gzip" | ||
| } | ||
|
|
||
| func (s) TestGzipWithoutFooter(t *testing.T) { |
There was a problem hiding this comment.
Is footer same as checksum?
And is this without footer or with invalid footer?
There was a problem hiding this comment.
Yes. I was originally planning to remove it entirely, but that caused a different error to occur. (We read the last 4 bytes as the size before decoding and detect a message that would be too large upon decompression, so signal ResourceExhausted.) I changed the test to modify the checksum, which is in the previous 4 bytes of the footer.
test/end2end_test.go
Outdated
| bs := buf.Bytes() | ||
| bs[len(bs)-4] -= 1 // modify checksum (big endian) at end by 1 byte | ||
| buf = bytes.NewBuffer(bs) | ||
| buf.WriteTo(w) |
There was a problem hiding this comment.
Is this same as w.Write(bs)?
There was a problem hiding this comment.
Yes, that's simpler, thanks.
Adds a regression test inspired by #3135.
Fixes #3135