eds: skip unhealthy endpoints #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown and healthy are both considered healthy.
dfawley
reviewed
Nov 4, 2019
| clab1.addLocality(testSubZones[0], 1, testEndpointAddrs[:3], &addLocalityOptions{ | ||
| health: []corepb.HealthStatus{ | ||
| corepb.HealthStatus_HEALTHY, | ||
| corepb.HealthStatus_UNHEALTHY, |
There was a problem hiding this comment.
Looks like there is also DRAINING, TIMEOUT, and DEGRADED. We should ideally include those as well.
dfawley
reviewed
Nov 4, 2019
menghanl
force-pushed
the
xds_eds_endpoint_health
branch
from
623a434
to
1669f79
Compare
menghanl
force-pushed
the
xds_eds_endpoint_health
branch
from
1669f79
to
a8bba8f
Compare
dfawley
approved these changes
Nov 4, 2019
| for i := 0; i < 4; i++ { | ||
| addr := <-cc.newSubConnAddrsCh | ||
| if addr[0].Addr != wantNewSubConnAddrStrs[i] { |
There was a problem hiding this comment.
Will they always happen in order?
Optional assuming they are always ordered for now: would a map[string]bool work better for wantNewSubConnAddrStrs? It could be more future-proof in case the order changes later. To ensure it doesn't do the same address four times, you could delete the entries from the map as they are pulled in from the channel.
There was a problem hiding this comment.
Now with sort and cmp.Equal
dfawley
approved these changes
Nov 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown and healthy are both considered healthy.
https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/core/health_check.proto#envoy-api-enum-core-healthstatus