Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop, examples: use localhost instead of 127.0.0.1 #3124

Merged
merged 1 commit into from Oct 28, 2019

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Oct 28, 2019

Made via:

grep -rl 127.0.0.1 | grep -v _test.go | xargs sed -i 's/127.0.0.1/localhost/g'

@easwars
Copy link
Contributor

easwars commented Oct 28, 2019

Made via:

grep -rl 127.0.0.1 | grep -v _test.go | xargs sed -i 's/127.0.0.1/localhost/g'

Why do we not want to do this for tests?

@dfawley
Copy link
Member Author

dfawley commented Oct 28, 2019

Current usages in tests all appear to be using it as an address or are unit tests, not to serve on a port or dial.

@dfawley dfawley merged commit 4ec516e into grpc:master Oct 28, 2019
@dfawley dfawley deleted the localhost branch October 28, 2019 21:41
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants