Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: create an example for enabling and configuring retry #3028

Merged
merged 17 commits into from Oct 3, 2019
Merged

examples: create an example for enabling and configuring retry #3028

merged 17 commits into from Oct 3, 2019

Conversation

abserari
Copy link
Contributor

@abserari abserari commented Sep 18, 2019 •
edited

@abserari abserari changed the title Retry example examples: create an example for enabling and configuring retry #3020 Sep 18, 2019
@dfawley dfawley added the Type: Documentation Documentation or examples label Sep 18, 2019
@dfawley dfawley self-assigned this Sep 26, 2019
@dfawley dfawley self-requested a review September 26, 2019 20:07
dfawley
dfawley requested changes Sep 26, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together, and sorry for the delay in the review. The basic structure of everything looks great! I have a lot of changes to request, but they all should be pretty minor.

examples/features/retry/README.md Outdated Show resolved Hide resolved
examples/features/retry/README.md Outdated Show resolved Hide resolved
examples/features/retry/README.md Outdated Show resolved Hide resolved
examples/features/retry/README.md Outdated Show resolved Hide resolved
examples/features/retry/client/main.go Outdated Show resolved Hide resolved
examples/features/retry/server/main.go Outdated Show resolved Hide resolved
examples/features/retry/server/main.go Outdated Show resolved Hide resolved
examples/features/retry/server/main.go Outdated Show resolved Hide resolved
examples/features/retry/README.md Outdated Show resolved Hide resolved
examples/features/retry/README.md Outdated Show resolved Hide resolved
@dfawley dfawley assigned abserari and unassigned dfawley Sep 26, 2019
@dfawley dfawley added this to the 1.25 Release milestone Sep 26, 2019
@dfawley dfawley assigned dfawley and unassigned abserari Sep 27, 2019
dfawley
dfawley approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@dfawley dfawley merged commit 3778847 into grpc:master Oct 3, 2019
@dfawley dfawley changed the title examples: create an example for enabling and configuring retry #3020 examples: create an example for enabling and configuring retry Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@dfawley dfawley

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.25 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abserari @dfawley