Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: fix a race that could lead to memory leaks #2765

Merged
merged 3 commits into from
Apr 15, 2019
Merged

transport: fix a race that could lead to memory leaks #2765

merged 3 commits into from
Apr 15, 2019

Conversation

canguler
Copy link

No description provided.

item is placed into controlbuf no matter what.
@canguler canguler changed the title When a RST_STREAM is received by the server transport, a cleanupStream is placed into controlbuf no matter what. internal: loopy writer estdstreams leak fix Apr 10, 2019
@dfawley dfawley changed the title internal: loopy writer estdstreams leak fix transport: fix a race that could lead to memory leaks Apr 11, 2019
@canguler canguler requested a review from menghanl April 15, 2019 17:25
@menghanl menghanl added this to the 1.21 Release milestone Apr 15, 2019
@canguler canguler merged commit 3fc7430 into grpc:master Apr 15, 2019
@menghanl
Copy link
Contributor

We need to backport this to 1.20 release.

canguler pushed a commit that referenced this pull request Apr 18, 2019
* When a RST_STREAM is received by the server transport, a cleanupStream
item is placed into controlbuf no matter what.

* Updates comments.

* Replaces getCleanupStream with inline struct initialization.
@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants