Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully switch balancers #2731

Closed
dfawley opened this issue Mar 29, 2019 · 3 comments
Closed

Gracefully switch balancers #2731

dfawley opened this issue Mar 29, 2019 · 3 comments
Assignees

Comments

@dfawley
Copy link
Member

dfawley commented Mar 29, 2019

When switching balancers, we currently Close the old balancer, but keep using its Pick method. Also, we do not update the balancer when the state of its subconns change. We should keep using the old balancer more fully until the new balancer indicates it is ready.

@menghanl
Copy link
Contributor

menghanl commented May 2, 2019

The first step is to stop using the picker after balancer is closed.
The fix for real graceful switch can happen later.

@stale
Copy link

stale bot commented Sep 6, 2019

This issue is labeled as requiring an update from the reporter, and no update has been received after 7 days. If no update is provided in the next 7 days, this issue will be automatically closed.

@stale stale bot added the stale label Sep 6, 2019
@dfawley dfawley removed the stale label Sep 6, 2019
@dfawley dfawley assigned easwars and unassigned menghanl Apr 27, 2022
@dfawley
Copy link
Member Author

dfawley commented Apr 27, 2022

Fixed by #5285

@dfawley dfawley closed this as completed Apr 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants