Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpclb proto and move grpclb into package grpc #1186

Merged
merged 9 commits into from
Apr 25, 2017

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Apr 14, 2017

To support loadBalancingPolicy field in service config, gRPC needs to import grpclb as a dependency. This causes a circular dependency: grpc->grpclb->grpc.

To resolve the circular dependency, this change moves the implementation of grpclb into grpc package.

@menghanl menghanl changed the title Update grpclb proto Update grpclb proto and move grpclb into package grpc Apr 20, 2017
@menghanl menghanl mentioned this pull request Apr 25, 2017
@menghanl menghanl merged commit c73e016 into grpc:master Apr 25, 2017
@menghanl menghanl added 1.3 Type: API Change Breaking API changes (experimental APIs only!) labels Apr 25, 2017
@tamird
Copy link
Contributor

tamird commented May 12, 2017

@dfawley it looks like grpclb/grpc_lb_v1/grpclb.pb.go was edited by hand here, which is cause make proto to produce import cycles.

@menghanl
Copy link
Contributor Author

Yes, grpclb is kind of special and is implemented in grpc package, so we need to edit this file to avoid import cycles at the first place.
Please ignoregrpclb.proto when regenerating pb.go files.

@menghanl menghanl deleted the update_grpclb_proto branch May 12, 2017 22:42
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants