fix: Fixes missing constructor in trimmed builds

[Blackclaws]

When trimming, the whole call chain for generics needs to be annotated with the same or broader scope of dynamically accessed members. See also: https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/fixing-warnings#dynamicallyaccessedmembers

This adds the required annotations up the call chain for the service extensions

Closes: #1969

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Blackclaws / name: Felix Winterhalter (5b41786)

[JamesNK]

Thanks. I wonder why trimming analysis didn't catch this?

TClient on the core method is annotated. Analysis should complain that the TClient passed from the calling methods to the core method isn't annotated with PublicConstructors.

[Blackclaws]

Thanks. I wonder why trimming analysis didn't catch this?

TClient on the core method is annotated. Analysis should complain that the TClient passed from the calling methods to the core method isn't annotated with PublicConstructors.

I does catch it. The problem is you need to actually publish a self-contained trimmed app for the trim analyzer to run correctly. See also: https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming#show-all-warnings-with-sample-application

So basically you have to add a sample application that references the library as a root assembly even if it does nothing and publish that to see the actual warnings.

[JamesNK]

Got it. There is a sample app in the tests for this purpose, but it didn't use the client factory. I'll update it.