Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 2.41.0-pre1 (on the release branch) #1479

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

jtattermusch
Copy link
Contributor

I will publish the pre-release right after merging this. Let me know if there's any blockers.

@JamesNK
Copy link
Member

JamesNK commented Nov 11, 2021

btw the reason for the failing tests is this line:

Assert.IsTrue(grpcVersion.Product!.Version!.Length <= 10);

The version is one character too long: 2.41.0-pre1

Change it to Assert.IsTrue(grpcVersion.Product!.Version!.Length <= 11);

I'm not sure why this hasn't failed before when the product name goes from 2.41.0-dev to 2.41.0-pre1. Something related to the user-agent string update?

@JamesNK
Copy link
Member

JamesNK commented Nov 11, 2021

The gRPC package version needs to be updated to 2.41.0?

<GrpcPackageVersion>2.40.0</GrpcPackageVersion>

@jtattermusch
Copy link
Contributor Author

Test failure should be fixed by #1486

@JamesNK
Copy link
Member

JamesNK commented Nov 12, 2021

Needs rebase, then it should pass.

@jtattermusch jtattermusch merged commit 341066e into v2.41.x Nov 12, 2021
@jtattermusch
Copy link
Contributor Author

@JamesNK I just pushed the nuget packages and created a release:
https://github.com/grpc/grpc-dotnet/releases/tag/v2.41.0-pre1
(and btw the new "autogenerate release notes" feature didn't seem to generate meaningful contents, so I left the release notes empty for now and they'll need to be filled in by hand).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants