Fix race between CompleteAsync and call dispose #1429
Merged
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
commented
Sep 29, 2021
Comment on lines
1063
to
1079
| var sentEndStreamCount = lastLogs.Count(l => | ||
| { | ||
| // This is HTTP/2 specific. If this test is run with HTTP/3 then this check will need to be updated. | ||
| if (l.EventId.Name == "Http2FrameReceived" && | ||
| l.State is IEnumerable<KeyValuePair<string, object>> state) | ||
| { | ||
| var frameType = state.Single(s => s.Key == "type").Value.ToString(); | ||
| var flags = state.Single(s => s.Key == "flags").Value.ToString(); | ||
|
|
||
| if (frameType == "DATA" && flags == "END_STREAM") | ||
| { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| }); |
There was a problem hiding this comment.
This is the only way I could figure out how to unit test this. I think if this test becomes troublesome then it could be deleted.
| @@ -996,5 +997,90 @@ async Task WaitForAllStreams(IAsyncStreamReader<DataMessage> requestStream, ISer | |||
| } | |||
| } | |||
| #endif | |||
|
|
|||
| [TestCase(2)] | |||
There was a problem hiding this comment.
I might've missed the nuance in the issue text but why are we testing on iterations up to 2 and 20?
There was a problem hiding this comment.
The race condition happened randomly.
When I was testing, I had 2 iterations so the logs weren't too long in one test run, and 20 in another run to ensure the race condition didn't happen over many iterations.
captainsafia
approved these changes
Sep 29, 2021
|
I hate the test. Removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1394