-
Notifications
You must be signed in to change notification settings - Fork 802
Create microsoft-support.md #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC @srini100 |
microsoft-support.md
Outdated
|
||
Notes: | ||
* Applications must be using a [currently supported .NET release](https://dotnet.microsoft.com/platform/support/policy). | ||
* Minimum supported grpc-dotnet version is v2.37.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you bump up the min version in future for any reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This number is incremented when new .NET versions are released. For example, when .NET 7 is released we'll increment the min version to the version referencing in the new project gRPC template. e.g. .NET 7 template references 2.45.0, which will become the new minimum.
Edit: Clarified in PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this number should be updated to v2.40.0, which is used by .NET 6 and was released since this document was written)
@thisisnotapril please review (to make sure this doc is compatible with CNCF's project requirements). |
* dotnet-grpc | ||
|
||
Notes: | ||
* Applications must be using a [currently supported .NET release](https://dotnet.microsoft.com/platform/support/policy). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.NET Native (UWP) support isn't called out on that page. Would that follow the same as .NET Framework where as long as it ships with Windows OS it'll be supported?
I'm going to close this. If it turns out it is desired then will reopen and address feedback. |
b05b645
to
770dc08
Compare
@jtattermusch Outstanding feedback answered. |
microsoft-support.md
Outdated
* Patches are provided (for free) as required for functional or security issues, typically [every 6 weeks](doc/release_process.md). | ||
* You can [contact Microsoft support to request help](https://support.serviceshub.microsoft.com/supportforbusiness/onboarding) (potentially at a cost). | ||
|
||
You can also request community support on GitHub (for free), but there is no guarantee of a quick reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: while "but there is no guarantee of a quick reply" is mostly true, I'm wondering if it makes community support (or the "official" gRPC support mentioned in the first paragraph, but not mentioned here) sound as a subpar alternative - and we don't want the users to interpret it as such. Can we simply add a note what the alternatives are (e.g. official support from gRPC team maintainers / community support) and refrain from statements that can be interpreted as assessing quality of some of the alternatives?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please consider making the initial note more visible (italics/bold+italics seems better than blockquote).
@jtattermusch The support document I mentioned.