Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make test" fails with go mod error #895

Closed
happyalu opened this issue Mar 6, 2019 · 3 comments
Closed

"make test" fails with go mod error #895

happyalu opened this issue Mar 6, 2019 · 3 comments

Comments

@happyalu
Copy link
Contributor

happyalu commented Mar 6, 2019

Step 5 in the Contributing Guide asks to run "make test".

When I ran make test, the tests failed with:

go: google.golang.org/cloud@v0.36.0: parsing go.mod: unexpected module path "cloud.google.com/go"

It seems that the CI is not running "make test".

Running go test ./... on a fresh clone ran without errors.

@johanbrandhorst
Copy link
Collaborator

Thanks for raising this issue. We need to look into what make test does that go test ./... doesn't cover, if anything. It may be we no longer need make test. The go mod error is indicative of something wrong with the mod file though which is also worrying.

@johanbrandhorst
Copy link
Collaborator

See also: #915. We'd love help to fix this!

@zachgersh
Copy link
Contributor

@johanbrandhorst - I think I've taken care of this now. make test does work now. Think you can close.

@happyalu - try it again if you have time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants