TestConvertDuration/invalid_duration failure

[pterjan]

🐛 Bug Report

Running tests fail here while building 1.14.7 or HEAD on x86_64

To Reproduce

$ git clone git@github.com:grpc-ecosystem/grpc-gateway.git
Cloning into 'grpc-gateway'...
remote: Enumerating objects: 5, done.
remote: Counting objects: 100% (5/5), done.
remote: Compressing objects: 100% (4/4), done.
remote: Total 9811 (delta 1), reused 1 (delta 1), pack-reused 9806
Receiving objects: 100% (9811/9811), 3.93 MiB | 9.10 MiB/s, done.
Resolving deltas: 100% (6847/6847), done.

$ cd grpc-gateway/runtime/

$ go test
go: downloading google.golang.org/grpc v1.31.1
go: downloading github.com/golang/protobuf v1.3.3
go: downloading google.golang.org/genproto v0.0.0-20200513103714-09dca8ec2884
--- FAIL: TestConvertDuration (0.00s)
    --- FAIL: TestConvertDuration/invalid_duration (0.00s)
        convert_test.go:129: got unexpected error
            &errors.errorString{s:"bad Duration: time: unknown unit \"years\" in duration \"123years\""}
            expected
            &errors.errorString{s:"bad Duration: time: unknown unit years in duration 123years"}
FAIL
exit status 1
FAIL	github.com/grpc-ecosystem/grpc-gateway/runtime	0.015s

Your Environment

Mageia Linux

go version go1.15 linux/amd64

[johanbrandhorst]

Ha, curious, I'm guessing this broke in 1.15. Thanks for the bug report, I can reproduce it. I've got a fix ready.

[johanbrandhorst]

Looks like the error was changed in golang/go@201cb04 (Go 1.15).