-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validator: add support for protoc-gen-validate 0.6.0 #417
validator: add support for protoc-gen-validate 0.6.0 #417
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
+ Coverage 73.98% 74.37% +0.38%
==========================================
Files 42 42
Lines 1357 1362 +5
==========================================
+ Hits 1004 1013 +9
+ Misses 299 295 -4
Partials 54 54
Continue to review full report at Codecov.
|
7fd373b
to
eaddd03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution! Could you please adapt this for our v2 branch? Thanks! |
bufbuild/protoc-gen-validate#455 changed the interface for the
Validate
call fromValidate()
toValidate(bool)
.I modified the middleware to support both.