Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator: add support for protoc-gen-validate 0.6.0 #417

Conversation

danielhochman
Copy link
Contributor

bufbuild/protoc-gen-validate#455 changed the interface for the Validate call from Validate() to Validate(bool).

I modified the middleware to support both.

@google-cla
Copy link

google-cla bot commented Apr 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@danielhochman danielhochman changed the title add support for protoc-gen-validate 0.6.0 validator: add support for protoc-gen-validate 0.6.0 Apr 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #417 (a703562) into master (165f605) will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
+ Coverage   73.98%   74.37%   +0.38%     
==========================================
  Files          42       42              
  Lines        1357     1362       +5     
==========================================
+ Hits         1004     1013       +9     
+ Misses        299      295       -4     
  Partials       54       54              
Impacted Files Coverage Δ
validator/validator.go 91.66% <100.00%> (+2.19%) ⬆️
retry/retry.go 75.92% <0.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165f605...a703562. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit df0f91b into grpc-ecosystem:master Apr 22, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you please adapt this for our v2 branch? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants