Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating gogo/protobuf to v1.3.2 from v1.2.1 to fix CVE-2021-3121 #416

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Updating gogo/protobuf to v1.3.2 from v1.2.1 to fix CVE-2021-3121 #416

merged 1 commit into from
Apr 21, 2021

Conversation

rehabaam
Copy link
Contributor

All tests passed by executing 'make all' and also by running another test command.

go-acc -o coverage.out ./... -- -timeout 30m
ok github.com/grpc-ecosystem/go-grpc-middleware 0.338s coverage: 95.2
ok github.com/grpc-ecosystem/go-grpc-middleware/auth 0.494s coverage: 35.0
? github.com/grpc-ecosystem/go-grpc-middleware/logging [no test files]
ok github.com/grpc-ecosystem/go-grpc-middleware/logging/kit 1.228s coverage: 72.6
ok github.com/grpc-ecosystem/go-grpc-middleware/logging/kit/ctxkit 0.237s coverage: 1.5
ok github.com/grpc-ecosystem/go-grpc-middleware/logging/logrus 1.688s coverage: 70.0
ok github.com/grpc-ecosystem/go-grpc-middleware/logging/logrus/ctxlogrus 0.260s coverage: 0.0
ok github.com/grpc-ecosystem/go-grpc-middleware/logging/settable 0.216s coverage: 50.0
ok github.com/grpc-ecosystem/go-grpc-middleware/logging/zap 1.261s coverage: 67.0
ok github.com/grpc-ecosystem/go-grpc-middleware/logging/zap/ctxzap 0.243s coverage: 8.6
ok github.com/grpc-ecosystem/go-grpc-middleware/ratelimit 0.238s coverage: 16.0
ok github.com/grpc-ecosystem/go-grpc-middleware/recovery 0.481s coverage: 51.0
ok github.com/grpc-ecosystem/go-grpc-middleware/retry 3.245s coverage: 57.4
ok github.com/grpc-ecosystem/go-grpc-middleware/tags 0.484s coverage: 42.1
? github.com/grpc-ecosystem/go-grpc-middleware/tags/logrus [no test files]
? github.com/grpc-ecosystem/go-grpc-middleware/tags/zap [no test files]
? github.com/grpc-ecosystem/go-grpc-middleware/testing [no test files]
? github.com/grpc-ecosystem/go-grpc-middleware/testing/gogotestproto [no test files]
? github.com/grpc-ecosystem/go-grpc-middleware/testing/testproto [no test files]
ok github.com/grpc-ecosystem/go-grpc-middleware/tracing/opentracing 0.589s coverage: 63.0
ok github.com/grpc-ecosystem/go-grpc-middleware/util/backoffutils 0.217s coverage: 66.7
ok github.com/grpc-ecosystem/go-grpc-middleware/util/metautils 0.221s coverage: 94.7
ok github.com/grpc-ecosystem/go-grpc-middleware/validator 0.443s coverage: 61.0

@google-cla
Copy link

google-cla bot commented Apr 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2021

Codecov Report

Merging #416 (933e867) into master (baff2d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #416   +/-   ##
=======================================
  Coverage   74.28%   74.28%           
=======================================
  Files          42       42           
  Lines        1357     1357           
=======================================
  Hits         1008     1008           
  Misses        295      295           
  Partials       54       54           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baff2d4...933e867. Read the comment docs.

@rehabaam
Copy link
Contributor Author

@googlebot I signed it!

@johanbrandhorst johanbrandhorst merged commit 165f605 into grpc-ecosystem:master Apr 21, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants