logging/zap/ctxzap: add shorthand functions #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAFxX
force-pushed
the
cafxx-ctxzap-shorthand
branch
2 times, most recently
from
62d7509
to
7360fbc
Compare
CAFxX
force-pushed
the
cafxx-ctxzap-shorthand
branch
from
7360fbc
to
2efb5e2
Compare
CAFxX
force-pushed
the
cafxx-ctxzap-shorthand
branch
from
2efb5e2
to
6ad06a4
Compare
|
Could you have a look at cherry-picking this to the v2 branch? It may need some rejigging. |
|
@johanbrandhorst it seems the whole package is missing in v2. Has it been left out on purpose, or it's simply still to be ported over? |
|
The logging infrastructure was refactored significantly in v2, but maybe https://github.com/grpc-ecosystem/go-grpc-middleware/blob/v2/providers/zap/logger.go is the place? |
|
Yeah saw that, but it seems all of those providers are missing the ctx* subpackage (like ctxzap here). Is it deliberate to not have the context based functionality, or just it hasn't been done yet? (One valid reason for not doing it may be the desire to write a generic-based implementation that works with any provider) |
|
CC @bwplotka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds common shorthand functions. See #407 for details.