v1: downgrade grpc requirements to <1.30.0 #381

drewwells · 2021-01-16T14:34:39Z

Refactors tests code to use local protobufs to avoid
importing grpc/examples. examples package uses bleeding
edge grpc forcing this package to be dependent on bleeding
edge latest grpc.

fixes #377

codecov-io · 2021-01-16T14:37:03Z

Codecov Report

Merging #381 (969c1c6) into master (4890039) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   73.50%   73.50%           
=======================================
  Files          41       41           
  Lines        1317     1317           
=======================================
  Hits          968      968           
  Misses        295      295           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4890039...969c1c6. Read the comment docs.

Refactors test code to use local protobufs instead of importing grpc/examples. examples package uses bleeding edge grpc forcing the pulling of bleeding edge grpc fixes grpc-ecosystem#377

bwplotka

Thanks,

This makes sense for v1, LGTM.

Just tiny suggestion 🤗

bwplotka · 2021-01-17T10:50:03Z

auth/examples_test.go

-// SayHello can be called by client without being authenticated by exampleAuthFunc as AuthFuncOverride is called instead
-func (g *gRPCserverUnauthenticated) SayHello(ctx context.Context, request *pb.HelloRequest) (*pb.HelloReply, error) {
-	return &pb.HelloReply{Message: "pong unauthenticated"}, nil
+// SayHello only can be called by client when authenticated by exampleAuthFunc


Let's stick to https://thanos.io/tip/contributing/coding-style-guide.md/#comments-should-be-full-sentences rule 🤗

Not a blocker, so let's merge.

bwplotka · 2021-01-17T10:51:18Z

Note we focus our forces on releasing v2. I think this is already fixed in v2.

downgrade grpc requirements to <1.30.0

969c1c6

Refactors test code to use local protobufs instead of importing grpc/examples. examples package uses bleeding edge grpc forcing the pulling of bleeding edge grpc fixes grpc-ecosystem#377

drewwells force-pushed the reduceGrpcVersion branch from 88aea59 to 969c1c6 Compare January 16, 2021 16:55

bwplotka approved these changes Jan 17, 2021

View reviewed changes

bwplotka changed the title ~~downgrade grpc requirements to <1.30.0~~ v1: downgrade grpc requirements to <1.30.0 Jan 17, 2021

bwplotka merged commit fab13c2 into grpc-ecosystem:master Jan 17, 2021

drewwells deleted the reduceGrpcVersion branch January 17, 2021 14:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1: downgrade grpc requirements to <1.30.0 #381

v1: downgrade grpc requirements to <1.30.0 #381

drewwells commented Jan 16, 2021 •

edited

codecov-io commented Jan 16, 2021 •

edited

bwplotka left a comment

bwplotka Jan 17, 2021

bwplotka Jan 17, 2021

bwplotka commented Jan 17, 2021

v1: downgrade grpc requirements to <1.30.0 #381

v1: downgrade grpc requirements to <1.30.0 #381

Conversation

drewwells commented Jan 16, 2021 • edited

codecov-io commented Jan 16, 2021 • edited

Codecov Report

bwplotka left a comment

Choose a reason for hiding this comment

bwplotka Jan 17, 2021

Choose a reason for hiding this comment

bwplotka Jan 17, 2021

Choose a reason for hiding this comment

bwplotka commented Jan 17, 2021

drewwells commented Jan 16, 2021 •

edited

codecov-io commented Jan 16, 2021 •

edited