From ef9ce028c91e1896c7f32e7c16455a2a8f86b969 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= Date: Thu, 4 Jun 2020 23:27:54 +0200 Subject: [PATCH] Drop ruby 2.3 support --- .github/workflows/windows.yml | 2 +- .travis.yml | 1 - parallel_tests.gemspec | 2 +- spec/integration_spec.rb | 2 +- spec/parallel_tests/test/runner_spec.rb | 2 +- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index cfe8a7ba..b3c39e74 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -8,7 +8,7 @@ jobs: strategy: fail-fast: false matrix: - ruby: [2.7, 2.6, 2.5, 2.4, 2.3] + ruby: [2.7, 2.6, 2.5, 2.4] steps: - uses: actions/checkout@master - name: Set up Ruby diff --git a/.travis.yml b/.travis.yml index 17c48a9e..e6dd9154 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,7 +1,6 @@ env: - RUBYOPT=-W0 rvm: - - 2.3 - 2.4 - 2.5 - 2.6 diff --git a/parallel_tests.gemspec b/parallel_tests.gemspec index 0feaafa4..8bbbd984 100644 --- a/parallel_tests.gemspec +++ b/parallel_tests.gemspec @@ -16,5 +16,5 @@ Gem::Specification.new name, ParallelTests::VERSION do |s| s.license = "MIT" s.executables = ["parallel_spinach", "parallel_cucumber", "parallel_rspec", "parallel_test"] s.add_runtime_dependency "parallel" - s.required_ruby_version = '>= 2.3.0' + s.required_ruby_version = '>= 2.4.0' end diff --git a/spec/integration_spec.rb b/spec/integration_spec.rb index 72be6244..23bc2a8a 100644 --- a/spec/integration_spec.rb +++ b/spec/integration_spec.rb @@ -426,7 +426,7 @@ def test_unicode write "features/fail2.feature", "Feature: xxx\n Scenario: xxx\n Given I fail" results = run_tests "features", :processes => 3, :type => "cucumber", :fail => true - failing_scenarios = if Gem.win_platform? && Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.4") + failing_scenarios = if Gem.win_platform? ["cucumber features/fail1.feature:2 # Scenario: xxx", "cucumber features/fail2.feature:2 # Scenario: xxx"] else ["cucumber features/fail2.feature:2 # Scenario: xxx", "cucumber features/fail1.feature:2 # Scenario: xxx"] diff --git a/spec/parallel_tests/test/runner_spec.rb b/spec/parallel_tests/test/runner_spec.rb index 26f6d72b..90a6fcf6 100644 --- a/spec/parallel_tests/test/runner_spec.rb +++ b/spec/parallel_tests/test/runner_spec.rb @@ -41,7 +41,7 @@ def call(*args) end it "uses given when passed found" do - result = Gem.win_platform? && Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.4") ? [["a", "b"], ["c"]] : [["a", "c"], ["b"]] + result = Gem.win_platform? ? [["a", "b"], ["c"]] : [["a", "c"], ["b"]] expect(call(["a", "b", "c"], 2, group_by: :found)).to eq(result) end