Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

901 - Record correct test file name #902

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

901 - Record correct test file name #902

wants to merge 1 commit into from

Conversation

yasirazgar
Copy link

@yasirazgar yasirazgar commented Apr 25, 2023 •
edited

Thank you for your contribution!

Fixes: #901

Checklist

  • Feature branch is up-to-date with master (if not - rebase it).
  • Added tests.
  • Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • Update Readme.md when cli options are changed

@yasirazgar yasirazgar changed the title 901 - crct testfile name 901 - Record correct test file name Apr 25, 2023
grosser
grosser reviewed Apr 26, 2023
View reviewed changes
Copy link
Owner

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, that looks interesting!
can you explain more on how this works/what this fixes
ideally inline so it's findable later
also a test would be nice so we don't break this later on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grosser grosser grosser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logs are not generated properly on using shoulda matchers or included tests
2 participants
@yasirazgar @grosser