Broken suite after upgrading 3.1.0 to 3.7.0 due to removal of ENV["RAILS_ENV"] || "test"

[smlsml]

Hello,

Our test suite runs our application against SQLite, Postgres, and SQL-Server. We use different RAILS_ENV settings for each of these "test_sqlite", "test_postgres", "test_sqlserver". The change in 3.2.0 to no longer honor RAILS_ENV prevents this from working.

Could we perhaps have a different/new environment variable so we can retain the old functionality but avoid the bug you all were trying to fix? Something like PARALLEL_RAILS_ENV or something that would normally not be set except when really needed?

Thanks!

[grosser]

#776 is what you are talking about I assume

yeah, an extra env var would work, PR welcome
if you have some other smart workaround that would be great too, idk how other test frameworks handle this sprint weirdness :(
... your usecase is less common afaik, so changing the default is not really an option

[smlsml]

I’ll make a small PR. I figure as long as it is a new, normally undefined ENV var that it won’t cause anyone an issue. I tried to monkey-patch it back to the original implementation in a variety of places (Rakefile and /initializers/) and couldn’t get it to work. Alternative was going to be re-writing the database.yml before execution but this will be quicker. Thanks for fast reply! Steve

…

On Fri, Apr 30, 2021 at 1:24 PM Michael Grosser ***@***.***> wrote: #776 <#776> is what you are talking about I assume yeah, an extra env var would work, PR welcome if you have some other smart workaround that would be great too, idk how other test frameworks handle this sprint weirdness :( ... your usecase is less common afaik, so changing the default is not really an option — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#817 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACXAZADGNFPRJKZ2FKH7PTTLMGZFANCNFSM433XTJNQ> .