Drop ruby 2.4 support and test against latest ruby & rails #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
dev_updates
branch
from
2cab66f
to
0ebdd59
Compare
Generated with ``` rails new spec/fixtures/rails61 --skip-listen --skip-spring --skip-bootsnap --skip-sprockets --skip-gemfile --skip-webpack-install rails _6.0.3_ new spec/fixtures/rails60 --skip-listen --skip-spring --skip-bootsnap --skip-sprockets --skip-gemfile --skip-webpack-install rm -rf spec/fixtures/rails61/.git spec/fixtures/rails60/.git git add spec/fixtures/rails6* ```
Through `bundle lock --add-platform x64-mingw32`. Favor that over `force_ruby_platform`.
deivid-rodriguez
force-pushed
the
dev_updates
branch
from
2041de7
to
b3e9c65
Compare
|
Ok, this PR got a bit out of hand, and it does a few different things. Happy to split it to separate PRs if needed. What it does is:
|
|
wow ... somehow even windows is happy 💖 |
|
Yeah, I cheated a bit, but all other similar specs were already skipped on Windows. |
|
Thanks! |
|
a few skipped tests is better than letting new red ones in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets the library in sync with Rails support range, which makes things easier.
Checklist
master(if not - rebase it).code introduces user-observable changes.