Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link after updating title #800

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Fix broken link after updating title #800

merged 2 commits into from
Feb 12, 2021

Conversation

clushie
Copy link
Contributor

@clushie clushie commented Feb 12, 2021

I've added GitLab support to the wiki page and adjusted the title.

Thank you for parallel_tests

I've added GitLab support to the wiki page and adjusted the title.
Readme.md Outdated
@@ -287,7 +287,7 @@ TIPS
`export PARALLEL_TEST_FIRST_IS_1=true` will provide the same result
- [email_spec and/or action_mailer_cache_delivery](https://github.com/grosser/parallel_tests/wiki)
- [zeus-parallel_tests](https://github.com/sevos/zeus-parallel_tests)
- [Distributed parallel test (e.g. Travis Support)](https://github.com/grosser/parallel_tests/wiki/Distributed-Parallel-Tests-and-Travis-Support)
- [Distributed Parallel Tests on CI systems (Travis, GitLab)](https://github.com/grosser/parallel_tests/wiki/Distributed-Parallel-Tests-on-CI-systems-(Travis,-GitLab))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we name it "CI Systems" ? ... otherwise it's just going to get longer forever :D

Suggested change
- [Distributed Parallel Tests on CI systems (Travis, GitLab)](https://github.com/grosser/parallel_tests/wiki/Distributed-Parallel-Tests-on-CI-systems-(Travis,-GitLab))
- [Distributed Parallel Tests on CI systems (Travis, GitLab, etc)](https://github.com/grosser/parallel_tests/wiki/Distributed-Parallel-Tests-on-CI-systems)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I've instead added Travis and GitLab in the text on the side (so it's still easy to find) and added another note since the distributed environment potentially allows to be integrated that way without supporting multiple-databases on one host.

@grosser grosser merged commit c081333 into grosser:master Feb 12, 2021
@grosser
Copy link
Owner

grosser commented Feb 12, 2021

thx!

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants