Highlight availability of ParallelTests module #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
reviewed
Aug 11, 2020
Readme.md
Outdated
| ``` | ||
|
|
||
| _note:_ when using the standalone runners (`parallel_rspec`, `parallel_test`, ...) then the `ParallelTests` module isn't available. |
There was a problem hiding this comment.
I though the fix would be to drop a require 'parallel_tests' at the top of the example ?
There was a problem hiding this comment.
And I thought you said it might not even be available as it's not even necessarily in the Gemfile. Although, then it should still have access to the gem and if it ran with bundle exec the command itself shouldn't work so it might work... 🤔
Eh, I'm unsure but you're probably right. Good we talked about it. Say the word and I'll change it again :)
There was a problem hiding this comment.
Added the explicit require
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #772
Thank you for your contribution!