Introduce Changelog and PR template #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of a PR template was requested in grosser#677 Here, I'm copying the one we use at authlogic, as a starting point. Of course, we can customize it to the needs of parallel_tests.
grosser
reviewed
Jun 10, 2020
grosser
reviewed
Jun 10, 2020
grosser
reviewed
Jun 10, 2020
grosser
reviewed
Jun 10, 2020
|
yah, this should help :) |
Co-authored-by: Michael Grosser <michael@grosser.it>
Co-authored-by: Michael Grosser <michael@grosser.it>
Co-authored-by: Michael Grosser <michael@grosser.it>
Co-authored-by: Michael Grosser <michael@grosser.it>
grosser
reviewed
Jun 10, 2020
grosser
reviewed
Jun 10, 2020
grosser
reviewed
Jun 10, 2020
| ### Dependencies | ||
|
|
||
| - Drop ruby 2.3 support (#760) | ||
| - Drop ruby 2.2 support (#759) |
There was a problem hiding this comment.
maybe just list these under breaking ?
There was a problem hiding this comment.
Happy to move them if you want. In my own projects, I don't like to set the expectation that dependency updates will always mean major bumps. And, SemVer does not consider dependency updates to be breaking changes (as long as the public API stays the same).
Co-authored-by: Michael Grosser <michael@grosser.it>
Co-authored-by: Michael Grosser <michael@grosser.it>
|
thx! |
|
|
||
| ### Breaking Changes | ||
|
|
||
| - Cucumber 3 support removed (#762) |
There was a problem hiding this comment.
Hi! I believe cucumber 3 should still work?
There was a problem hiding this comment.
ah yes ... this was just the sorting part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Michael. I just upgraded to 3, and it seems to be working fine. I thought I'd add a changelog to help other people to upgrade.
[Fixes #677]