cleanup pattern matching #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
force-pushed
the
grosser/exclude
branch
from
8509890
to
cab2c8d
Compare
nc-annenk
reviewed
Feb 8, 2019
| files.grep(options[:suffix] || test_suffix) | ||
| .grep(options[:pattern] || //) | ||
| files = files.grep(suffix_pattern).grep(include_pattern) | ||
| files -= files.grep(exclude_pattern) if exclude_pattern |
There was a problem hiding this comment.
Moving the filtering of the exclusion into this block means folders are not filtered out. If the goal is to mirror the functionality of rspec --pattern and `--exclude-pattern, wouldn't the folder need to have the regexes applied as well?
There was a problem hiding this comment.
it means files that are explicitly added are not affected by filters
folders are still effected since they are covered to files and then matched against
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleanup for #682
fyi @nc-annenk