From 135673d211aa5e970127a63379c4eb49da37c68a Mon Sep 17 00:00:00 2001
From: Chris Gunther <chris@room118solutions.com>
Date: Thu, 27 Aug 2020 21:30:17 -0400
Subject: [PATCH] Force RAILS_ENV to be "test" in rake tasks (#776)

After #732, if you're using the SQL schema format, `parallel:prepare`
now calls `db:purge db:structure:load` where it used to call
`db:test:prepare`. The old task forced using the test environment,
however the new tasks make no assumptions about the environment.
Therefore, when combined with a Spring-ified rake binstub, where Spring
defaults to the development environment, when `parallel:prepare` calls
`db:purge db:structure:load`, they're running in the development
environment against the development database, instead of in the test
environment against the test database.

Now the environment is forced to be "test" in all rake tasks regardless
of the RAILS_ENV that might have been set, whether by Spring or the
user. This has the side-effect of removing the ability to run the tasks
in a test-like environment that's named something other than "test".

I believe this fixes #768.
---
 CHANGELOG.md                      | 4 ++--
 lib/parallel_tests/tasks.rb       | 2 +-
 spec/parallel_tests/tasks_spec.rb | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index af0bad05..0baa9a53 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,7 +4,7 @@
 
 ### Breaking Changes
 
-- None
+- RAILS_ENV cannot be specified for rake tasks (#776).
 
 ### Added
 
@@ -12,7 +12,7 @@
 
 ### Fixed
 
-- None
+- Rake tasks will no longer run against development environment when using a Spring-ified rake binstub (#776).
 
 ## 3.1.0 - 2020-07-23
 
diff --git a/lib/parallel_tests/tasks.rb b/lib/parallel_tests/tasks.rb
index 415ac1fc..406fece4 100644
--- a/lib/parallel_tests/tasks.rb
+++ b/lib/parallel_tests/tasks.rb
@@ -5,7 +5,7 @@ module ParallelTests
   module Tasks
     class << self
       def rails_env
-        ENV['RAILS_ENV'] || 'test'
+        'test'
       end
 
       def rake_bin
diff --git a/spec/parallel_tests/tasks_spec.rb b/spec/parallel_tests/tasks_spec.rb
index acc93d2d..0ab65b6b 100644
--- a/spec/parallel_tests/tasks_spec.rb
+++ b/spec/parallel_tests/tasks_spec.rb
@@ -35,13 +35,13 @@
   end
 
   describe ".rails_env" do
-    it "should be test when nothing was set" do
+    it "should be test" do
       expect(ParallelTests::Tasks.rails_env).to eq("test")
     end
 
-    it "should be whatever was set" do
+    it "should disregard whatever was set" do
       ENV["RAILS_ENV"] = "foo"
-      expect(ParallelTests::Tasks.rails_env).to eq("foo")
+      expect(ParallelTests::Tasks.rails_env).to eq("test")
     end
   end