Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or Update a contributors link of @masatomo #293

Merged
merged 1 commit into from Mar 1, 2021
Merged

Fix or Update a contributors link of @masatomo #293

merged 1 commit into from Mar 1, 2021

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Mar 1, 2021

git log --author='masatomo'
git log --author='Masatomo Nakano'

Both hits only bccbec4

I couldn't find any source of masatomon@reallyenglish.com,
But @masatomo has https://github.com/masatomo/parallel_tests
I guess this is a his work 馃槃.

`git log --author='masatomo'`
`git log --author='Masatomo Nakano'`

Both hits only bccbec4

I couldn't find any source of `masatomon@reallyenglish.com`,
But @masatomo has https://github.com/masatomo/parallel_tests
I guess this is a his work 馃槃.
@kachick
Copy link
Contributor Author

kachick commented Mar 1, 2021

masatomo/parallel_tests@9d0aa60

git show HEAD

commit 9d0aa60794b063803897fd5b019042a2192320d1 (HEAD -> master, origin/master, origin/HEAD)
Author: Masatomo Nakano <masatomon@reallyenglish.com>
Date:   Wed Aug 25 14:32:30 2010 +0100

    Replace <%= ENV['TEST_ENV_NUMBER'] %> with test number of parallel build in (parallel_)spec.opts .
    e.g. you can set "--format html:spec/spec-reports/index<%= ENV['TEST_ENV_NUMBER'] %>.html" in (parallel_)spec.opts

diff --git a/lib/parallel_specs.rb b/lib/parallel_specs.rb
index 5a1eaf1..bc413e4 100644
--- a/lib/parallel_specs.rb
+++ b/lib/parallel_specs.rb
@@ -1,8 +1,9 @@
 require File.join(File.dirname(__FILE__), 'parallel_tests')
+require 'erb'

 class ParallelSpecs < ParallelTests
   def self.run_tests(test_files, process_number, options)
-    cmd = "#{color} #{executable} #{options} #{spec_opts} #{test_files*' '}"
+    cmd = "#{color} #{executable} #{options} #{spec_opts(process_number)} #{test_files*' '}"
     execute_command(cmd, process_number)[:stdout]
   end

馃憖 masatomon@reallyenglish.com

@kachick kachick changed the title [RFC] Fix Contributors link Fix or Update a contributors link of @masatomo Mar 1, 2021
@grosser
Copy link
Owner

grosser commented Mar 1, 2021

thx!

@grosser grosser merged commit 41f0fc2 into grosser:master Mar 1, 2021
@kachick
Copy link
Contributor Author

kachick commented Mar 1, 2021

Thank you!

@kachick kachick deleted the tomosan branch March 1, 2021 05:20
@masatomo
Copy link

masatomo commented Mar 1, 2021

that's right. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants