Use update instead of update_attributes #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarsh2102
force-pushed
the
use-update
branch
from
d2aa189
to
cf174a7
Compare
|
please rebase on master to fix the build issues |
update_attributes has been deprecated and removed in Rails 6 and onward, thereby making this test fail with newer Rails. Fixes: grosser#135
utkarsh2102
force-pushed
the
use-update
branch
from
cf174a7
to
de6d6cb
Compare
|
2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_attributeshas been deprecated andremoved in Rails 6 and onward, thereby
making this test fail with newer Rails.
Fixes: #135