Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchain awereness #29

Open
hsynkrtl opened this issue Sep 12, 2022 · 4 comments
Open

Toolchain awereness #29

hsynkrtl opened this issue Sep 12, 2022 · 4 comments

Comments

@hsynkrtl
Copy link

Make groovy-maven-plugin aware of settings maven-toolchains-plugin. In speciall switching the jvm.

@jdillon
Copy link
Member

jdillon commented Sep 15, 2022

what "switching the jvm" do you mean? gmaven 2 uses the existing JVM to execute Groovy implementations, not sure how becoming toolchain aware helps, but maybe i'm missing something?

@morm
Copy link

morm commented Mar 23, 2023

I support this issue. It's a real problem the plugin not supporting toolchains.
https://maven.apache.org/guides/mini/guide-using-toolchains.html

@jdillon
Copy link
Member

jdillon commented Mar 29, 2023

FTR I still do not really get what the value of "toolchains" are here, but if someone can explain it to me or provide a PR to express the value i'm certainly open to considering supporting it.

@morm
Copy link

morm commented Mar 29, 2023

Here's my scenario: I'm working on a large project that's composed of various modules. While each module depends on the parent's properties, it also has its own dependencies and requires specific JDK settings for source and target versions. To build the parent project with all its modules, I'm using toolchains that support multiple JDK versions (1.8, 11, 13, and 17). Most of the plugins I'm using also support toolchains. However, I've encountered an issue with gmaven, which is used by one of the new modules I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants