Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a fork option to prepare toolchain support #282

Open
bmarwell opened this issue Oct 14, 2023 · 1 comment · May be fixed by #283
Open

Create a fork option to prepare toolchain support #282

bmarwell opened this issue Oct 14, 2023 · 1 comment · May be fixed by #283

Comments

@bmarwell
Copy link
Contributor

Before we implement toolchains, I suggest to implement a fork parameter first.

Rationale:

  • Forking is needed for toolchains anyway, as groovyc will be called
  • Toolchains without forking might be possible, but is not necessary to implement. Loading additional jars is not trivial.
  • We can define parameters for the toolchain.

That said, sdkman uses GROOVY_HOME=…. If that doesn't yield anything for fork mode to use, just look for groovyc in the $PATH. If that did not find anything, abort.

Toolchain Support for #43 would just need to read the toolchain variable and use that installDir parameter (or similar) instead of the default $GROOVY_HOME.
@bmarwell
Copy link
Contributor Author

Related: see <fork> for the maven compiler plugin as reference.

@bmarwell bmarwell changed the title Allow a forkMode (or just fork) to prepare toolchain support Create a fork option to prepare toolchain support Oct 14, 2023
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 14, 2023
@bmarwell
[groovy#282] add groovy.fork property and fork paramter.
748bf51
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 14, 2023
@bmarwell
[groovy#282] find groovyc in GROOVY_HOME and PATH
b779c97
@bmarwell bmarwell linked a pull request Oct 14, 2023 that will close this issue
Open
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 14, 2023
@bmarwell
[groovy#282] groovc invocation
e5c020f
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
0d0b250
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
3adc8e1
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
3297fb7
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
29df3d5
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
71f39f9
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
7d6196a
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
bfb376f
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
baaff2a
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 15, 2023
@bmarwell
[groovy#282] install groovy in CI
c612b1e
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 16, 2023
@bmarwell
[groovy#282] print warnings for unsupported options
4868d37
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 18, 2023
@bmarwell
[groovy#282] remove dangling class file
be20b07
bmarwell added a commit to bmarwell/GMavenPlus that referenced this issue Oct 18, 2023
@bmarwell
[groovy#282] fix unwrapping of this.parallelParsing
24e98ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#282] fork parameter bmarwell/GMavenPlus
1 participant
@bmarwell