Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-module classpath issues (closes #183) #185

Merged
merged 1 commit into from Dec 13, 2020

Conversation

keeganwitt
Copy link
Member

@keeganwitt keeganwitt commented Dec 10, 2020

Problems

  • Plugin ClassLoader is re-used between modules, so classpath was a super-set of all modules that proceeded it (since dependencies were being added to plugin ClassRealm, which adds to plugin ClassLoader).
  • Execute, Console, and Shell mojos didn't pass the ClassLoader to use to GroovyShell, so the plugin ClassLoader was accidentally being used, including for PROJECT_ONLY configuration.

Changes

  • Pass ClassLoader to GroovyShell in Execute, Console, and Shell mojos.
  • Load project dependencies into a new ClassLoader, instantiated per mojo execution instead of using Plexus Classworld.

@keeganwitt keeganwitt force-pushed the 183/submodule_classpath_issues branch 2 times, most recently from 5816788 to df21666 Compare December 13, 2020 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant