Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSS security issue in Markdown component #4105

Closed
DanielBaird opened this issue May 20, 2020 · 3 comments · Fixed by #4123
Closed

XSS security issue in Markdown component #4105

DanielBaird opened this issue May 20, 2020 · 3 comments · Fixed by #4123
Assignees
Labels
bug issue that does not match design or documentation and requires code changes to address waiting Awaiting response to latest comments

Comments

@DanielBaird
Copy link
Contributor

npm reports a security issue with the Markdown component.

https://npmjs.com/advisories/1219

This parallels issue 306 in the markdown-to-jsx library. When they fix theirs, we can fix ours.

Expected Behavior

npm audit should report no security issues with Grommet.

Actual Behavior

$ npm audit

                       === npm audit security report ===

┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Cross-Site Scripting                                         │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ markdown-to-jsx                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ No patch available                                           │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ @jcu/webapp                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ @jcu/webapp > grommet > markdown-to-jsx                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1219                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
@ShimiSun ShimiSun added bug issue that does not match design or documentation and requires code changes to address waiting Awaiting response to latest comments labels May 21, 2020
@DanielBaird
Copy link
Contributor Author

Markdown-to-jsx released 6.11.4 that probably fixes the issue; they're not sure what it will take to convince NPM of that.

I guess grommet should hold off and see if there's another version soon that is NPM-approved

https://github.com/probablyup/markdown-to-jsx/releases/tag/6.11.4

@ShimiSun
Copy link
Member

@shovelmn12 FYI.

@rwhogg
Copy link

rwhogg commented May 28, 2020

quantizor/markdown-to-jsx#306 has been closed now and npm has marked v6.11.4 as fixing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue that does not match design or documentation and requires code changes to address waiting Awaiting response to latest comments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants