Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addSubGrid does not work: TypeError: Failed to execute 'appendChild' on 'Node': #2553

Closed
vmihailenco opened this issue Nov 28, 2023 · 4 comments
Labels

Comments

@vmihailenco
Copy link
Contributor

vmihailenco commented Nov 28, 2023

The documention has this section

subgrid

  1. It does not seem to work: https://jsfiddle.net/3adz58bm/ (click on Add widget)
_display/?editor_console=true:142 Uncaught TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type 'Node'.
    at addNewWidget (_display/?editor_console=true:142:9)
    at HTMLButtonElement.onclick (_display/?editor_console=true:119:34)
  1. It mentions makeSubgrid, but uses addSubGrid.

  2. Probably makeSubgrid has a typo and it should be makeSubGrid.

@adumesny
Copy link
Member

you can't just add any div to a grid and not makeWidget() first, then figure out on to make content by a subgrid, which is a dup of #2553. closing.

@vmihailenco
Copy link
Contributor Author

I just copy paste the exact code you have in docs. Also, you've pasted the link to this very issue.

@adumesny
Copy link
Member

meant #2554 - reopening as at very least doc has to change. sorry...

@adumesny adumesny reopened this Nov 29, 2023
@adumesny
Copy link
Member

adumesny commented Dec 1, 2023

fixed in #2555

@adumesny adumesny closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants