Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addWidget() & load() fix for existing element #2131

Merged
merged 1 commit into from Dec 29, 2022

Conversation

adumesny
Copy link
Member

Description

  • we now support calling addWidget() when there is an existing HTML element not yet initialized, but with creation options
  • load() also now supports the same
  • make sure grid and items have the correct GS styles (don't assume callee does when they init()/addWidget()

these are required by new Angular wrapper to optimizes updates. #2130

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* we now support calling addWidget() when there is an existing HTML element not yet initialized, but with creation options
* load() also now supports the same
* make sure grid and items have the correct GS styles (don't assume callee does when they init()/addWidget()

these are required by new Angular wrapper to optimizes updates.
@adumesny adumesny merged commit 744f707 into gridstack:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant