Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular component examples #2129

Merged
merged 2 commits into from Dec 28, 2022
Merged

Angular component examples #2129

merged 2 commits into from Dec 28, 2022

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Dec 28, 2022

Description

  • better version of Angular wrapper example improvement #1824

  • moved classes to correct place, simplified htm + css to be in .ts template (only 2 files to copy now)

  • fixed the incorrect event handlers to pass the right set of params for each, cleanup

  • grid-item simpler elements (matches Nodes fields)

  • GridStackEventHandlerCallback is not a list of specific callbacks so user can have better method signatures.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

* GridStackEventHandlerCallback is not a list of specific callbacks so user can have better method signatures.
* better version of gridstack#1824
* moved classes to correct place, simplified htm + css to be in .ts template (only 2 files to copy now)
* fixed the incorrect event handlers to pass the right set of params for each, cleanup
* grid-item simpler elements (matches Nodes fields)

MORE TODO....
@adumesny adumesny merged commit 8f0b663 into gridstack:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant