Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid elements can be resized outside of the bound defined by row option. #2055

Closed
Voodu opened this issue Sep 29, 2022 · 2 comments
Closed
Labels

Comments

@Voodu
Copy link

Voodu commented Sep 29, 2022

Subject of the issue

row setting is not respected and elements can be resized outside of grid bounds defined by row setting.

The bug was introduced in version 6.0.2. The previous one, 6.0.1, seems to be working just fine.

Your environment

  • gridstack@6.0.2
  • tested on Chrome and Firefox, Ubuntu 20.04

Steps to reproduce

https://jsfiddle.net/pkyjg2sw/
This can be reproduced in two ways:

  1. Resize the upper element downward, pushing the bottom one down.
  2. Resize the bottom element downward. Might need some wigging with the mouse at the bottom of the screen, but it's also possible.

Expected behavior

Resizing the upper element vertically shouldn't be possible due to fixed rows option

Actual behavior

Resizing is possible, the bottom element is pushed downwards and everything gets out of defined rows bounds.

@adumesny
Copy link
Member

adumesny commented Sep 29, 2022

| bug was introduced in version 6.0.2. The previous one, 6.0.1

thank you, that makes it easier to track. You fix some bugs, and apparently introduce new ones :)

Note: apparently maxRow=1 doesn't force horizontal movement either (same issue #2056).

adumesny added a commit to adumesny/gridstack.js that referenced this issue Oct 8, 2022
* fix bug introduced when fixing gridstack#2043 (checking for 50% coverage before swap)
adumesny added a commit that referenced this issue Oct 8, 2022
fix #2055 maxRow=1 resize outside
@adumesny
Copy link
Member

adumesny commented Oct 8, 2022

fixed in 6.0.3 - don't forget to donate if you find this lib useful!

@adumesny adumesny closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants