Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serialize-javascript dependency #1307

Closed
dappjumper opened this issue Aug 12, 2020 · 1 comment
Closed

Bump serialize-javascript dependency #1307

dappjumper opened this issue Aug 12, 2020 · 1 comment

Comments

@dappjumper
Copy link

Description

NPM Audit produces High-severity alert for a vue-server-renderer called serialize-javascript

This can be fixed on projects by adding

"serialize-javascript": ">=3.1.0"

To my project's package.json, but it should be done on gridsome itself, not for every new project using gridsome

Steps to reproduce

Create any gridsome cli app and try running it

Expected result

No high severity issues out-of-the-box

Actual result

High severity issue out-of-the-box

Environment

  System:
    OS: Windows 10 10.0.18362
    CPU: (8) x64 Intel(R) Core(TM) i7-4710HQ CPU @ 2.50GHz
  Binaries:
    Node: 12.13.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.4 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 6.12.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 84.0.4147.105
    Edge: Spartan (44.18362.449.0)
  npmPackages:
    gridsome: ^0.7.0 => 0.7.19
@hjvedvik
Copy link
Member

I noticed the security message earlier today. A PR for upgrading it was merged in vue-server-renderer some hours ago. You should be able to update your lock file once they have publish a new version :)

@hjvedvik hjvedvik closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants